]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
loginDialog: Split out getBannerText() helper
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 22 Nov 2024 18:23:59 +0000 (19:23 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Tue, 4 Feb 2025 12:10:09 +0000 (13:10 +0100)
The new methods will make it easier to add alternative sources
for the banner text.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3558>

js/gdm/loginDialog.js

index 27baae83ad513869f07a261e98997506b02ebb8c..c3c397c0d1791f7bfab33c3b73945de2d08a8139 100644 (file)
@@ -873,11 +873,18 @@ export const LoginDialog = GObject.registerClass({
         this._authPrompt.cancelButton.visible = cancelVisible;
     }
 
+    _getBannerText() {
+        const enabled = this._settings.get_boolean(GdmUtil.BANNER_MESSAGE_KEY);
+        if (!enabled)
+            return null;
+
+        return this._settings.get_string(GdmUtil.BANNER_MESSAGE_TEXT_KEY);
+    }
+
     _updateBanner() {
-        let enabled = this._settings.get_boolean(GdmUtil.BANNER_MESSAGE_KEY);
-        let text = this._settings.get_string(GdmUtil.BANNER_MESSAGE_TEXT_KEY);
+        const text = this._getBannerText();
 
-        if (enabled && text) {
+        if (text) {
             this._bannerLabel.set_text(text);
             this._bannerLabel.show();
         } else {